Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ripd 1869 tm ledger data duplicates #4

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Fix/ripd 1869 tm ledger data duplicates #4

merged 3 commits into from
Aug 14, 2024

Conversation

vlntb
Copy link

@vlntb vlntb commented Aug 13, 2024 •
edited by ximinez
Loading

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

This change is Reviewable

@ximinez ximinez changed the base branch from develop to ci/getledger August 13, 2024 18:11
@vlntb vlntb changed the base branch from ci/getledger to develop August 13, 2024 18:30
@ximinez ximinez changed the base branch from develop to ci/getledger August 13, 2024 18:36
@ximinez ximinez force-pushed the fix/RIPD-1869-TMLedgerData-duplicates branch from 1b7d912 to 3df5f94 Compare August 13, 2024 20:07
@ximinez
Copy link
Owner

ximinez commented Aug 13, 2024

I changed the base branch to ci/getledger, squashed this branch down to one commit, and rebased it against master so that it doesn't conflict.

vlntb and others added 2 commits August 14, 2024 16:11
@vlntb @ximinez
make receiveddata a set
55995fc 
trace to check duplicates detection

using HashRouter

use MessageToJsonString for hashing

remove previous experiments

remove previous experiments 1

remove previous experiments 2

cleanup

refactor in template

refactor in template 1

added unit tests
@ximinez
Fix formatting
0f99ce5
@ximinez ximinez force-pushed the fix/RIPD-1869-TMLedgerData-duplicates branch from 7e48bac to 0f99ce5 Compare August 14, 2024 20:16
@ximinez ximinez merged commit dc406ba into ximinez:ci/getledger Aug 14, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlntb @ximinez